CA-377169 block VM.checkpoint of running VM with VTPM #4997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
May 11, 2023
The current VTPM implementation saves the TPM content only when the VM halts. THus, taking a checkpoint while the VM is running would not save the corrent TPM state. Block this. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
psafont
approved these changes
May 12, 2023
edwintorok
approved these changes
May 12, 2023
There was a problem hiding this comment.
Suspend should correctly read back the vtpm state (same as a migrate), however I see that we take a snapshot info prior to suspend which may have outdated data and it is not clear which one "wins" when restoring the checkpoint: the one from the "migration stream" in the suspend VDI or the VM snapshot properties from xapi db.
You're right it is safer to block this until it is properly implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current VTPM implementation saves the TPM content only when the VM halts. THus, taking a checkpoint while the VM is running would not save the corrent TPM state. Block this.