Skip to content

CA-377169 block VM.checkpoint of running VM with VTPM #4997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023
Merged

CA-377169 block VM.checkpoint of running VM with VTPM #4997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ocaml/xapi/xapi_vm_snapshot.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,15 @@ let compare_snapid_chunks s1 s2 =
let checkpoint ~__context ~vm ~new_name =
Xapi_vmss.show_task_in_xencenter ~__context ~vm ;
let power_state = Db.VM.get_power_state ~__context ~self:vm in
let vtpms = Db.VM.get_VTPMs ~__context ~self:vm in
let snapshot_info = ref [] in
( match (power_state, vtpms) with
| `Running, _ :: _ ->
let message = "VM.checkpoint of running VM with VTPM" in
Helpers.maybe_raise_vtpm_unimplemented __FUNCTION__ message
| _ ->
()
) ;
(* live-suspend the VM if the VM is running *)
( if power_state = `Running then
try
Expand Down
2 changes: 1 addition & 1 deletion quality-gate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ structural-equality () {
}

vtpm-unimplemented () {
N=6
N=7
VTPM=$(git grep -r --count 'maybe_raise_vtpm_unimplemented' -- **/*.ml | cut -d ':' -f 2 | paste -sd+ - | bc)
if [ "$VTPM" -eq "$N" ]; then
echo "OK found $VTPM usages of vtpm unimplemented errors"
Expand Down