CP-308545 Add host.timezone #6758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
use examples: python sdk APIs print(session.xenapi.host.get_timezone(host_ref))
session.xenapi.host.set_timezone(host_ref, 'Europe/London')
print(session.xenapi.host.get_timezone(host_ref))
try:
session.xenapi.host.set_timezone(host_ref, 'Europe/Londom')
except Exception as e:
print(e)
print(session.xenapi.host.list_timezones(host_ref))output: xe commands |
changlei-li
force-pushed
the
private/changleli/add-timezone
branch
from
1064533 to
5e3f968
Compare
psafont
reviewed
Nov 17, 2025
changlei-li
force-pushed
the
private/changleli/add-timezone
branch
from
5e3f968 to
4ef9bcc
Compare
minglumlu
reviewed
Nov 18, 2025
| ~ssh_enabled_timeout ~ssh_expiry ~console_idle_timeout ~ssh_auto_mode | ||
| ~max_cstate:"" ~secure_boot ~ntp_mode:`ntp_mode_dhcp ~ntp_custom_servers:[] | ||
| ~ntp_enabled:false ; | ||
| ~ntp_enabled:false ~timezone:"UTC" ; |
Member
There was a problem hiding this comment.
(Not related with this PR)
Just to confirm: the timezone should be reserved when a host joins a pool.
Contributor
Author
There was a problem hiding this comment.
For pool join case, the new-joined host will keep its own timezone. For example, coordinator is 'UTC', host A is 'Asia/Shanghai' before join. Then hostA joins the pool and reboot, the hostA dbsync will set its timezone field to 'Asia/Shanghai' according to the real setting on host.
The test result
# xe host-list params=uuid,timezone
uuid ( RO) : f910aa46-0e52-4a86-8bdf-634ea894c32a
timezone ( RW): UTC
uuid ( RO) : ff2efb83-326a-4842-8b98-8e2efef32d3c
timezone ( RW): Asia/Shanghai
Member
There was a problem hiding this comment.
For pool join, the host will first be added to the pool database using this function, with UTC as timezone. Then xapi will restart and dbsync will update it to the real timezone.
minglumlu
approved these changes
Nov 18, 2025
minglumlu
reviewed
Nov 18, 2025
ocaml/idl/datamodel_host.ml
Outdated
| ~params: | ||
| [ | ||
| (Ref _host, "self", "The host") | ||
| ; (String, "value", "The timezone to set, e.g., 'Europe/London'") |
Member
There was a problem hiding this comment.
How about to get it clear as:
The time zone identifier as defined in the IANA Time Zone Database.
New filed: host.timezone APIs: host.set_timezone, host.get_timezone, host.list_timezones Signed-off-by: Changlei Li <changlei.li@cloud.com>
changlei-li
force-pushed
the
private/changleli/add-timezone
branch
from
4ef9bcc to
5f0e5cd
Compare
Signed-off-by: Changlei Li <changlei.li@cloud.com>
changlei-li
force-pushed
the
private/changleli/add-timezone
branch
from
5f0e5cd to
f677ea7
Compare
psafont
approved these changes
Nov 18, 2025
changlei-li
merged commit 4a67e13
into
xapi-project:feature/config-ntp-timezone-maxcstate
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.