rrdd: support multiple vm_uuid/sr_uuid query parameters#6938
Merged
psafont merged 1 commit intoxapi-project:masterfrom Mar 6, 2026
Merged
rrdd: support multiple vm_uuid/sr_uuid query parameters#6938psafont merged 1 commit intoxapi-project:masterfrom
psafont merged 1 commit intoxapi-project:masterfrom
Conversation
psafont
reviewed
Mar 6, 2026
0d621ac to
f52e16b
Compare
lindig
approved these changes
Mar 6, 2026
Allow the rrd_updates handler to accept multiple vm_uuid and sr_uuid query parameters in the HTTP query. Previously only a single value was supported via List.assoc. You can now pass URL parameters like "?vm_uuid=XXX&vm_uuid=YYY". This also simplifies the query parsing code and makes the filtering logic reusable for both VM and SR RRDs. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
f52e16b to
1acecd6
Compare
psafont
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the rrd_updates handler to accept multiple vm_uuid and sr_uuid parameters in the HTTP query. Previously only a single value was supported via List.assoc.
This also simplifies the query parsing code and makes the filtering logic reusable for both VM and SR RRDs.