CP-311257: Raise proper error code#6963
Merged
liulinC merged 2 commits intoxapi-project:feature/ldapsfrom Mar 23, 2026
Merged
Conversation
`try_map_any f l` apply f on l and return - Ok if any `f e` succeed - Error list if all failed Signed-off-by: Lin Liu <lin.liu01@citrix.com>
liulinC
force-pushed
the
private/linl/errmsg
branch
from
f8b19a6 to
de6f8c9
Compare
- Define new errors for invalid certificate, pool and host level - Remove AD joined check as it was already done in extauth.ml - Move certificate to extauth_plugin_ADwinbind.ml so it can shared between set-ldaps and enable-ad - ping_domain use try_map_any to propagate the error details Signed-off-by: Lin Liu <lin.liu01@citrix.com>
liulinC
force-pushed
the
private/linl/errmsg
branch
from
de6f8c9 to
da6c8bf
Compare
lindig
approved these changes
Mar 20, 2026
| in | ||
| loop [] l | ||
|
|
||
| let try_map_any f l = |
Contributor
There was a problem hiding this comment.
Does this code not return the result of f x? So what is the purpose of this code then?
Collaborator
Author
There was a problem hiding this comment.
Yes, I think it return either
- Ok value
- Error (e list)
Contributor
There was a problem hiding this comment.
You are right. ok binds the result.
minglumlu
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.