CA-427727: Failed to join host to pool due to ldaps sync failed#7089
Open
liulinC wants to merge 1 commit into
Open
CA-427727: Failed to join host to pool due to ldaps sync failed#7089liulinC wants to merge 1 commit into
liulinC wants to merge 1 commit into
Conversation
ldaps sync failed is ignored by ignore_error by intention, however, `@@` is right-associative low-precedence application and the fun () -> body greedily absorbs every following statement until the enclosing delimiter, the second ignore_error is part of the first lambda's body, thus, the exception in first ignore_error(sync ldaps) skiped the second ignore_error function body, e.g: update_non_vm_metadata and later got no change to execute. The issue is fixed by removing `@@` and providing function body enclosed Signed-off-by: Lin Liu <lin.liu01@citrix.com>
Collaborator
Author
|
xenrt job 4653177 looks good. |
psafont
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ldaps sync failed is ignored by ignore_error by intention, however,
@@is right-associative low-precedence application and the fun () -> body greedily absorbs every following statement until the enclosing delimiter, the second ignore_error is part of the first lambda's body, thus, the exception in first ignore_error(sync ldaps) skiped the second ignore_error function body, e.g: update_non_vm_metadata and later got no change to execute.The issue is fixed by removing
@@and providing function body enclosed