feature branch sync#7110
Merged
Merged
Conversation
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
…-project#7079) Also: place the temporary file in the target folder in all cases and not only when the latter is under a different root from the client application,
- winbind_kerberos_encryption_type default to strong - https_only default to true - Remove scripts/xe-switch-network-backend - Remove scripts/xe-switch-network-backend-bash-completion Signed-off-by: Lin Liu <lin.liu01@citrix.com>
When running `xe sm-list params=all` you will now have the info of supported image formats if the SM plugin specified it in its DRIVER_INFO. The field is called `supported-image-formats`. If the plugin doesn't provide the info the field will be empty. This patch modifies the datamodel and add a new field to store this information into the SM object. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
This patch allows specifying the destination format for individual VDIs mapped to a destination SR. It adds a new parameter to `VM.migrate_send` and `VM.assert_can_migrate` API. It also adds a new parameter to XE CLI. The format to specify the image format is `image-format:<source VDI UUID>=<destination image format>`. If the given image format cannot be validated, an error is returned. It also adds a new parameter to `VDI.pool-migrate`. This new parameter allows to provide a string that is the destination format. This string is used to check whether the destination SR supports the expected format. If the check fails or cannot be performed due to missing information on the destination SR, an error is returned. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
Update VM.MigrateSend call to include new VdiFormatMap parameter. Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
A new field supported_image_format and new parameters have been added for: - VM.migrate_send - VM.assert_can_migrate - VDI.pool_migrate Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
Introduce a new quicktest covering local VDI migration between two Storage Repositories (SRs). Add a `migration_path` filter that injects a `(src, dst)` SR pair derived from an `SR.srs` constraint. The filter selects a single valid migration path (if available) and generates one test case. If fewer than two compatible SRs exist, no test is produced. The test: - Creates a VDI on the source SR - Attaches it to a temporary VM - Calls VDI.pool_migrate to the destination SR - Verifies that the VDI's SR has changed accordingly - Cleans up safely, tracking ownership transfer when migration replaces the original VDI Signed-off-by: Guillaume <guillaume.thouvenin@vates.tech>
From Semaphore document: try_acquire s immediately returns false if the value of semaphore s is zero. Otherwise, the value of s is atomically decremented and try_acquire s returns true. Signed-off-by: Changlei Li <changlei.li@citrix.com>
- winbind_kerberos_encryption_type default to strong - https_only default to true - Remove scripts/xe-switch-network-backend - Remove scripts/xe-switch-network-backend-bash-completion
This PR implements the supported image format mechanism proposed in this design document: https://xapi-project.github.io/new-docs/design/sm-supported-image-formats/index.html - It adds supported image formats to the SM object if the SM plugin specifies it in its `DRIVER_INFO`. - When the information is available, you can select which image format to use as the destination during a VM or VDI migration. This feature is particularly useful because XCP-ng is adding support for the Qcow2 format in SMAPI to allow _VDIs_ larger than 2TB. So in the near future (we're currently releasing the beta version), some _SRs_ will support multiple formats such as VHD, RAW, and Qcow2. With this patch, it becomes possible to migrate a VM with VHD disks on one SR to another SR with Qcow2 disks. If an SM plugin does not provide information about the supported image formats, the behavior remains unchanged. For more details see the [specification](https://xapi-project.github.io/new-docs/design/sm-supported-image-formats/index.html).
Signed-off-by: Seb Hinderer <sebastien.hinderer@vates.tech>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Seb Hinderer <sebastien.hinderer@vates.tech>
Actually seems more correct here than Indeed. Signed-off-by: Seb Hinderer <sebastien.hinderer@vates.tech>
…t#7092) From Semaphore document: try_acquire s immediately returns false if the value of semaphore s is zero. Otherwise, the value of s is atomically decremented and try_acquire s returns true.
Actually seems more correct here than Indeed.
Signed-off-by: Colin James <colin.barr@vates.tech>
Signed-off-by: Colin James <colin.barr@vates.tech>
Signed-off-by: Colin James <colin.barr@vates.tech>
- Removes the enumeratee type abbreviation, as it's less terse than
spelling out the iteratee transformer function type ('a t -> 'a t t).
- Removes unused combinators from iteratees, such as "apply". The use
case for this is largely subsumed by writing effectful enumeratees,
such as the extant "stream_printer" adapter.
- Removes "extract_result_from_iteratee". This is unused but, in
general, it should have been partial, casing on the iteratee after
sending EOF to it (as the equivalent "run" function does in the
original iteratee resources).
Signed-off-by: Colin James <colin.barr@vates.tech>
Removes some unused combinators from wsproxy and adds some stylistic changes (mostly preferring let-operators over infix monadic bind `>>=`). These are just some changes I made when learning the iteratee style used in wslib/wsproxy. --- In future, we may rewrite wsproxy so as to remove the iteratee style (as it's not convenient for other websocket use cases, like a websocket server in full generality).
Collaborator
Author
|
Fix the scheme hash: |
BengangY
approved these changes
Jun 2, 2026
changlei-li
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.