CP-54442: Update for network devices not being renamed#57
Conversation
A new proposed change in networkd will replace the interface-rename functionality to order the network devices. The result of the ordering performed by interface-rename is to rename the devices like eth0, eth1, etc. The new change in networkd will not rename the devices any more. Consequently, the use of hard-coded eth<N> in network reset in xsconsole should be eliminated to cope with the new change. Additionally, the new networkd replacing the interface rename functionality will perform the network reset with xapi together. The interface rename functionality will be deprecated in the future. Signed-off-by: Ming Lu <ming.lu@cloud.com>
minglumlu
changed the base branch from
master
to
feature/host-network-device-ordering
The Ubuntu 24.04 can't support Python2. So in short term, update it to Ubuntu 22.04. Signed-off-by: Ming Lu <ming.lu@cloud.com>
| - name: Install dependencies | ||
| run: | | ||
| #: Install Python 2.7 from Ubuntu 20.04 using apt-get install | ||
| #: Install Python 2.7 from Ubuntu 22.04 using apt-get install |
There was a problem hiding this comment.
Should python3 be installed instead?
There was a problem hiding this comment.
The Python2 is still in the pipeline :(
So it can not be updated to Ubuntu 24.04 in which the Python2 is not supported.
See the commit message of a26db00
There was a problem hiding this comment.
Well, shouldn't python2 be removed from the pipeline altogether, then?
There was a problem hiding this comment.
The Python2 was not removed when doing the migration from Python2 to Python3. I think there might be a reason for that.
There was a problem hiding this comment.
well, the master branch is compatible with Python2/Python3 by @bernhardkaindl ,
That is the reason why python2 check is still valid. (Although I think we should branch out for Yangtze if necessary and keep master clean for Python3 only)
| # determine the bridge name. | ||
|
|
||
| # Ensure xapi is not running | ||
| os.system('service xapi stop >/dev/null 2>/dev/null') |
There was a problem hiding this comment.
not related to your PR, but
service command is no longer valid in XS9,
is it possible for you to update it to systemctl stop xapi
There was a problem hiding this comment.
well, let's focus on your task,
We will fix it latter in another PR
minglumlu
merged commit 70ade8e
into
xapi-project:feature/host-network-device-ordering
3 participants
A new proposed change in networkd will replace the interface-rename functionality to order the network devices. The result of the ordering performed by interface-rename is to rename the devices like eth0, eth1, etc. The new change in networkd will not rename the devices any more. Consequently, the use of hard-coded eth in network reset in xsconsole should be eliminated to cope with the new change.
Additionally, the new networkd replacing the interface rename functionality will perform the network reset with xapi together.
The interface rename functionality will be deprecated in the future.