Skip to content

Fix mypy checks#630

Merged
dcherian merged 1 commit intoxarray-contrib:mainfrom
bouweandela:fix-mypy
Apr 1, 2026
Merged

Fix mypy checks#630
dcherian merged 1 commit intoxarray-contrib:mainfrom
bouweandela:fix-mypy

Conversation

@bouweandela
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.00%. Comparing base (a9cebee) to head (b00d04b).
⚠️ Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   85.78%   87.00%   +1.22%     
==========================================
  Files          13       15       +2     
  Lines        2364     3225     +861     
  Branches      183      305     +122     
==========================================
+ Hits         2028     2806     +778     
- Misses        303      374      +71     
- Partials       33       45      +12     
Flag Coverage Δ
mypy 45.91% <ø> (+7.37%) ⬆️
unittests 92.77% <ø> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouweandela bouweandela marked this pull request as ready for review April 1, 2026 15:33
)
)

elif value is Ellipsis:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is unreachable because the function always_iterable never returns Ellipsis

@dcherian dcherian merged commit 5d05556 into xarray-contrib:main Apr 1, 2026
13 checks passed
@bouweandela bouweandela deleted the fix-mypy branch April 1, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants