Allow all numpy float data types, not just numpy.float64#122
Merged
brendancol merged 1 commit intoxarray-contrib:masterfrom Aug 18, 2020
Merged
Allow all numpy float data types, not just numpy.float64#122brendancol merged 1 commit intoxarray-contrib:masterfrom
brendancol merged 1 commit intoxarray-contrib:masterfrom
Conversation
Xarray-spatial checks if data array data types are a subclass of numpy.float. However, numpy.float is an alias of builtins.float, of which only numpy.float64 is subclassed. Changing numpy.float to numpy.floating allows all numpy float data types.
Contributor
|
@jthetzel Thanks for the PR. We are reviewing and will get it merged ASAP. So great to have another contributor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xarray-spatial checks if data array data types are a subclass
of numpy.float. However, numpy.float is an alias of
builtins.float, of which only numpy.float64 is subclassed.
Changing numpy.float to numpy.floating allows all numpy float
data types.