Skip to content

Drop final master references after default branch rename#1266

Merged
brendancol merged 1 commit intomainfrom
master-cleanup-followup
Apr 25, 2026
Merged

Drop final master references after default branch rename#1266
brendancol merged 1 commit intomainfrom
master-cleanup-followup

Conversation

@brendancol
Copy link
Copy Markdown
Contributor

@brendancol brendancol commented Apr 25, 2026

Summary

Cleans up the last few "master" occurrences that survived the rename PRs (#1255, #1260):

  • .github/workflows/test.yml: pins actions/checkout@master -> @v4 and actions/setup-python@master -> @v5, matching the version tags already used in benchmarks.yml. Tracking @master exposes the workflow to unreleased changes in those actions' repos.
  • docs/source/conf.py: renames master_doc to root_doc. root_doc has been Sphinx's canonical name since Sphinx 4.0; master_doc remains as a deprecated alias. Also updates the header-comment URL from the old sphinx-doc.org/en/master/config redirect to the stable docs path.
  • docs/source/_templates/docs-navbar.html: matching master_doc -> root_doc rename.
  • benchmarks/asv.conf.json: trims the now-irrelevant "defaults to master" template comment (the branches key is explicitly set).

After this merges, no master references remain in .github/, docs/, benchmarks/, README.md, CONTRIBUTING.md, or .claude/commands/.

Test plan

  • CI passes on this PR (the pytest workflow uses the newly-pinned actions).
  • Sphinx docs build successfully (Read the Docs build).
  • Site renders with logo link working (relies on pathto(root_doc) in the navbar template).

Cleans up the few occurrences of "master" left in the repo after the
master->main default branch rename:

- test.yml pins actions/checkout and actions/setup-python to versioned
  tags (@v4 and @v5) instead of @master, matching the version pattern
  already used in benchmarks.yml. This also fixes a minor stability
  concern: tracking @master picks up unreleased changes from those
  actions' repos.
- conf.py renames master_doc to root_doc (Sphinx's modern canonical
  name; supported as an alias since Sphinx 4.0).
- docs-navbar.html template updated to match.
- The Sphinx docs URL in the conf.py header comment now points at
  the stable docs path.
- Trims an obsolete "defaults to master" comment in asv.conf.json
  since branches is explicitly set.
@github-actions github-actions Bot added the performance PR touches performance-sensitive code label Apr 25, 2026
@brendancol brendancol merged commit 7c81aca into main Apr 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PR touches performance-sensitive code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant