Record accuracy sweep results for corridor#1414
Merged
brendancol merged 2 commits intomainfrom May 2, 2026
Merged
Conversation
No CRIT/HIGH issues found. One LOW issue noted: corridor inherits float32 from cost_distance, which can lose precision near the min when costs accumulate to large values (intrinsic to upstream dtype).
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: brendancol <433221+brendancol@users.noreply.github.com>
Contributor
Merge conflicts resolved in 30c60be. The CSV now includes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xrspatial/corridor.pyagainst the 5 accuracy categories (precision loss, NaN/Inf propagation, off-by-one, projection corrections, backend inconsistency).cost_distancesonormalized = corridor - corridor_mincan lose precision near the min when costs accumulate to large values. The arithmetic in corridor itself does not introduce extra loss.corridor.min()usesskipna=True, the result is checked withnp.isfinitebefore normalization, and unreachable corridors return all-NaN.dask.where,cupy.where, ornp.wherevia a try/except pattern.Test plan