rasterize: fail fast on GPU scanline edge cap (#2067)#2072
Merged
Conversation
The CUDA scanline kernel allocates a fixed-size cuda.local.array(2048) for active edges per row. Rows exceeding that cap silently truncated and produced wrong output. The eager CuPy path issued a RuntimeWarning but still returned the corrupted raster. The Dask+CuPy tile path had no check at all, so per-tile truncation was silent. Both paths now share _check_gpu_edge_cap(row_ptr) which raises a ValueError pointing the caller at the numpy backend. Closes #2067
# Conflicts: # xrspatial/tests/test_rasterize.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CUDA polygon scanline kernel allocates a fixed-size
cuda.local.array(2048)for active edges per raster row. Rows exceeding that cap silently truncated and produced wrong output.RuntimeWarningbut still return the corrupted raster.Both paths now call a shared
_check_gpu_edge_cap(row_ptr)that raises aValueErrorpointing the caller at the numpy/dask+numpy backend.The validator runs host-side, so the regression test does not need a GPU.
Closes #2067
Test plan
test_gpu_edge_cap_check_raisesconstructs arow_ptrexceeding the cap and assertsValueError.test_gpu_edge_cap_check_passes_at_limitconfirms exactly-at-cap is permitted.