Fix flake8 E128 and isort drift in interpolate/_kriging.py#2918
Merged
Conversation
Re-indent the two _chunk_var kriging-predict continuation lines in the dask backends to the visual-indent column (E128), and collapse the xrspatial.utils import block to one line under line_length=100 (isort). Behaviour-neutral style cleanup. Also records the kriging row in the style-sweep state file.
brendancol
commented
Jun 4, 2026
Contributor
Author
brendancol
left a comment
brendancol
left a comment
There was a problem hiding this comment.
PR Review: Fix flake8 E128 and isort drift in interpolate/_kriging.py
No blockers, suggestions, or nits.
The diff is whitespace and import-layout only:
- Two E128 continuation lines re-indented to the visual-indent column in the
_chunk_varhelpers of_kriging_dask_numpyand_kriging_dask_cupy. - The
xrspatial.utilsimport block collapsed to one 88-char line, under the configured 100.
No logic changed, so backend parity, NaN handling, and edge cases are unaffected. flake8 and isort are clean on the file and the 14 kriging tests pass.
The state-CSV row reordering is the expected effect of the row-sorted rewrite of .claude/sweep-style-state.csv; content for other modules is unchanged.
Checklist
- No behavioural change (style-only)
- flake8 + isort clean on the module
- Existing kriging tests pass (14)
- No new public API; README/docs unaffected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2916
Style cleanup for
xrspatial/interpolate/_kriging.py. The project's configured tooling (setup.cfg: flake8max-line-length=100, isortline_length=100) reports these but CI does not gate them._chunk_varkriging-predict continuation lines in_kriging_dask_numpyand_kriging_dask_cupyto the visual-indent column.from xrspatial.utils import (...)block to one 88-char line.No behavioural change. The edits are whitespace and import-layout only; they apply uniformly across the numpy/cupy/dask backend paths dispatched by
ArrayTypeFunctionMapping.Cat 2 (W-codes), Cat 3 (F-codes), and Cat 5 (bare except, mutable defaults,
== None/== True, shadowed builtins) all came back clean.Also records the
interpolate-krigingrow in.claude/sweep-style-state.csv.Test plan:
flake8 xrspatial/interpolate/_kriging.pycleanisort --check-only xrspatial/interpolate/_kriging.pycleanpytest xrspatial/tests/test_interpolation.py -k kriging(14 passed)