geotiff: cover compress()/decompress() dispatcher error branches (#2995)#2996
Merged
brendancol merged 1 commit intoJun 6, 2026
Conversation
Add TestDispatcherErrorBranches to unit/test_codec_roundtrip.py pinning the five untested guard raises in the codec dispatchers: - compress() rejects JPEG / JPEG2000 / LERC with a redirect to the block-codec entry points (these need width/height/samples). - compress() and decompress() reject unknown compression tags via the else branch. Test-only; source unchanged. 5 tests, all passing locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2995.
Test-coverage sweep finding (Cat 4, error-path coverage). The codec dispatchers in
xrspatial/geotiff/_compression.pyhad five guard raises that no test exercised:compress(data, COMPRESSION_JPEG | COMPRESSION_JPEG2000 | COMPRESSION_LERC)-- the byte-stream entry point cannot encode block codecs (they need width/height/samples), so it raises a redirect to the dedicated*_compress()helpers.compress()anddecompress()reject unknown tags via theirelsebranch.Adds
TestDispatcherErrorBranchestounit/test_codec_roundtrip.py(5 tests). The constants and thecompress/decompressdispatchers were already imported in that module, so no new imports were needed.Source is unchanged. All 5 new tests pass locally (full file: 117 passed).