Skip to content

Conversation

@calexat-123
Copy link
Contributor

No description provided.

@marcozimmermannpm marcozimmermannpm added ready to merge PR is ready to merge WIP Work in progress labels Apr 14, 2021
@thuydotm
Copy link
Contributor

thuydotm commented Apr 16, 2021

@lex-c let's change this to sum of absolute instead (even their results are equal)

manhattan_distance(x1, y1, x2, y2) = abs(x1 - x2) + abs(y1 - y2)

@calexat-123 calexat-123 removed the WIP Work in progress label Apr 23, 2021
@giancastro giancastro requested a review from thuydotm April 28, 2021 20:39
@thuydotm thuydotm changed the title fix manhattan distance to sum of square roots fix manhattan distance to sum of abs May 4, 2021
@thuydotm
Copy link
Contributor

thuydotm commented May 4, 2021

This looks good to me, let's get this merged!

@thuydotm thuydotm merged commit 9b7f44d into xarray-contrib:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge PR is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants