Skip to content

add Github Action to publish package to PyPI #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brendancol merged 31 commits into from
Apr 21, 2021
Merged

add Github Action to publish package to PyPI #371

brendancol merged 31 commits into from
Apr 21, 2021

Conversation

@giancastro
Copy link
Contributor

@giancastro giancastro commented Apr 19, 2021

This PR solves the issue #359.

@giancastro giancastro added the WIP Work in progress label Apr 19, 2021
@giancastro giancastro self-assigned this Apr 19, 2021
@giancastro giancastro linked an issue Apr 19, 2021 that may be closed by this pull request
Create GitHub Action to publish xrspatial on pypi #359
Closed
@giancastro giancastro requested a review from brendancol April 19, 2021 16:05
@giancastro giancastro added DGP and removed WIP Work in progress labels Apr 19, 2021
@giancastro giancastro marked this pull request as ready for review April 19, 2021 16:05
@brendancol
Copy link
Contributor

brendancol commented Apr 20, 2021

@giancastro hey I added the PYPI_API_TOKEN secret to the repo

@giancastro
Copy link
Contributor Author

giancastro commented Apr 20, 2021

@brendancol cool! is this PR ready to merge?

@giancastro giancastro added the WIP Work in progress label Apr 20, 2021
@giancastro
Copy link
Contributor Author

giancastro commented Apr 20, 2021 •
edited
Loading

@brendancol, could you add a new GitHub secret TEST_PYPI_API_TOKEN from test.pypi?

@giancastro giancastro added ready to merge PR is ready to merge and removed WIP Work in progress labels Apr 21, 2021
@giancastro giancastro removed the DGP label Apr 21, 2021
brendancol
brendancol reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@brendancol brendancol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendancol brendancol merged commit b043b8c into master Apr 21, 2021
@giancastro giancastro deleted the package-publish branch May 5, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendancol brendancol brendancol left review comments

Assignees

@giancastro giancastro

Labels

ready to merge PR is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create GitHub Action to publish xrspatial on pypi

3 participants

@giancastro @brendancol