Skip to content

add make terrain sample data function #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brendancol merged 6 commits into from
May 25, 2021
Merged

add make terrain sample data function #439

brendancol merged 6 commits into from
May 25, 2021

Conversation

@giancastro
Copy link
Contributor

@giancastro giancastro commented May 24, 2021

This PR solves the issue #437.

@giancastro giancastro added the ready to merge PR is ready to merge label May 24, 2021
@giancastro giancastro requested a review from brendancol May 24, 2021 20:09
@giancastro giancastro linked an issue May 24, 2021 that may be closed by this pull request
Add generate_terrain dask support with noise #437
Closed
@giancastro
Copy link
Contributor Author

giancastro commented May 25, 2021

@brendancol

brendancol
brendancol reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@brendancol brendancol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make noise optional dependency
  • try: except ImportError: must install noise to use terrain pip install noise
  • remove noise from setup.py

@brendancol brendancol merged commit d89d302 into master May 25, 2021
@giancastro giancastro deleted the terrain-dataset branch June 24, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendancol brendancol brendancol left review comments

Assignees

No one assigned

Labels

ready to merge PR is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add generate_terrain dask support with noise

3 participants

@giancastro @brendancol