Fixes #879: memory-guarded KDTree with tiled fallback for proximity#892
Merged
brendancol merged 1 commit intomasterfrom Feb 25, 2026
Merged
Fixes #879: memory-guarded KDTree with tiled fallback for proximity#892brendancol merged 1 commit intomasterfrom
brendancol merged 1 commit intomasterfrom
Conversation
The dask KDTree path in proximity() accumulated all target coordinates in memory before building a global cKDTree, causing OOM on dense rasters. Replace the unbounded accumulation with a two-phase approach: - Phase 0: stream chunks counting targets, cache coords within 25% budget - Memory decision: if global tree estimate < 50% available RAM, build a single cKDTree (fast, lazy via da.map_blocks); otherwise fall back to a tiled expanding-ring KDTree (eager but memory-safe) The tiled path builds local trees per output chunk, expanding the search ring until a boundary-distance validation proves correctness. A ResourceWarning is emitted when the tiled fallback activates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_process_dask_kdtree()with a streaming count pass that caches coords within a 25% memory budgetda.map_blockspath (functionally identical to before); otherwise → tiled expanding-ring KDTree fallback (eager, memory-safe)ResourceWarningwhen tiled fallback activatesTest plan