Skip to content

Fix plotting test #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2025
Merged

Fix plotting test #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d77f2c3
update precommit hooks
barisoztas Nov 18, 2025
e00fb52
fix single custom geometry plotting test
barisoztas Nov 18, 2025
eb8104c
create geometry column manually
barisoztas Nov 19, 2025
234e504
reroll changes in the test
barisoztas Nov 19, 2025
36341f7
only when index and geom len matches
barisoztas Nov 19, 2025
122f6d4
add upstream issue to the workaround
barisoztas Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
files: 'xvec\/'
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.12.2
rev: v0.14.5
hooks:
- id: ruff
- id: ruff-format
Expand Down
6 changes: 6 additions & 0 deletions xvec/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,12 @@ def to_geodataframe(
return df.set_geometry(geometry, crs=self._obj.proj.crs)

# coordinate geometry
Copy link
Member

@martinfleis martinfleis Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a comment here explaining what is happening with a link to the xarray issue? I'd like to see this as a temporary measure until it gets fixed in upstream.

# Workaround for xarray 2025.10.1 bug where coordinates with names
# different from dimension names are not included in to_dataframe()
# See: https://github.com/pydata/xarray/issues/9903
if len(df.index) == len(self._obj[geometry].values):
df[geometry] = self._obj[geometry].values

return df.set_geometry(
geometry, crs=self._obj[geometry].attrs.get("crs", None)
) # type: ignore
Expand Down