Fix update failres on generated columns#820
Merged
Merged
Conversation
kvch
approved these changes
May 20, 2026
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
17 tasks
tsg
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #754 introduced a regression for replicating updates on
GENERATED ALWAYS AS IDENTITYcolumns. It was meant to avoid generating identity columns on the target, so that FKs stay valid. But INSERT and UPDATE share the same filterRowColumns path, so any UPDATE that includes an always-identity column in the SET clause is rejected by Postgres.The fix is that
buildUpdateQuerynow callsfilterRowColumnsForAction(..., forUpdate=true), which additionally drops always-identity columns from the SET clause. INSERT, bulk INSERT, and COPY paths are untouched.Added more tests to cover more of the scenarios. Current state is:
Fixes #821.
Test_SnapshotToPostgres_IdentityOnlyTable(real coverage via #754's path)Test_PostgresToPostgres_IdentityColumns(real coverage)Test_PostgresToPostgres_AlwaysIdentityUpdate(integration smoke; UPDATE is filtered via the existinggeneratedColumnspath, so it passes either way — the new filter is dead code in this integration test)TestDMLAdapter_walDataToQuerieswith emptygeneratedColumns+ populatedalwaysIdentityColumns) — integration coverage isn't feasible without dismantlingTestMain's DDL-trigger installType of Change
Please select the relevant option(s):
Changes Made
Testing
Checklist
Additional Notes