Skip to content

Conversation

@xavierpellvidal
Copy link
Owner

Screenshot tests not working
Added some VM tests

@xavierpellvidal xavierpellvidal requested a review from Copilot April 17, 2025 20:06
@xavierpellvidal xavierpellvidal self-assigned this Apr 17, 2025
@xavierpellvidal xavierpellvidal changed the base branch from main to epic/users-feature April 17, 2025 20:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on improving testing and overall project structure by adding new VM tests and updating various modules. It also enhances dependency injection setups, navigation components, and updates naming for consistency.

  • Introduced a new DatabaseModule and ApiModule for Room and Retrofit configurations.
  • Updated navigation components and refactored the application class name.
  • Removed an outdated ExampleUnitTest sample.

Reviewed Changes

Copilot reviewed 70 out of 74 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/database/src/main/kotlin/com/random/users/database/di/DatabaseModule.kt Provides Room database instance via Hilt DI.
core/database/src/main/kotlin/com/random/users/database/dao/UserDao.kt Introduces DAO for deleted user operations.
core/database/src/main/kotlin/com/random/users/database/RandomUsersDatabase.kt Defines RoomDatabase with entity registrations.
core/api/src/test/kotlin/com/example/data/ExampleUnitTest.kt Removed sample unit test; consider validating API behavior elsewhere.
core/api/src/main/kotlin/com/random/users/api/service/UsersApi.kt Declares Retrofit API interface using Arrow Either adapter.
core/api/src/main/kotlin/com/random/users/api/model/GetUsersResponse.kt Adds data classes for API response deserialization.
core/api/src/main/kotlin/com/random/users/api/di/ApiModule.kt Sets up Retrofit, OkHttp client, and provides API service.
app/src/main/kotlin/com/random/user/view/MainActivity.kt Updates Compose theme and embeds the base project application UI.
app/src/main/kotlin/com/random/user/navigation/viewmodel/NavigationViewModel.kt Implements a ViewModel for navigation using a set of feature navigators.
app/src/main/kotlin/com/random/user/navigation/di/NavigationModule.kt Provides feature navigation implementation via multi-bindings.
app/src/main/kotlin/com/random/user/navigation/RandomUsersNavHost.kt Configures navigation host using dynamic graph registration.
app/src/main/kotlin/com/random/user/navigation/RandomUsersApp.kt Wraps the navigation host in a composable application entry point.
app/src/main/kotlin/com/random/user/application/RandomUsersApplication.kt Renames application class for consistency.
README.md Updates project documentation to reflect new testing and feature implementations.
Files not reviewed (4)
  • app/build.gradle.kts: Language not supported
  • app/src/main/AndroidManifest.xml: Language not supported
  • core/api/build.gradle.kts: Language not supported
  • core/database/build.gradle.kts: Language not supported
Comments suppressed due to low confidence (1)

core/api/src/test/kotlin/com/example/data/ExampleUnitTest.kt:1

  • The removal of ExampleUnitTest leaves a gap in test coverage for the API layer; please ensure that alternative tests are added to validate API functionality.
-package com.example.data

@xavierpellvidal xavierpellvidal merged commit e632669 into epic/users-feature Apr 17, 2025
@xavierpellvidal xavierpellvidal deleted the feature/screenshot-tests branch April 18, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants