-
Notifications
You must be signed in to change notification settings - Fork 0
[FEATURE] Remaining tests #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the remaining unit tests and makes several codebase improvements. Key changes include:
- Modifications to UserCard in the presentation layer (access modifiers and testTag additions).
- Updates to dependency versions and module/package imports in gradle, data, and API modules.
- Addition of new unit tests for use cases, repositories, and helper factories.
- Documentation enhancements in the README and minor version bumping in the AppVersions file.
Reviewed Changes
Copilot reviewed 37 out of 40 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| presentation/users/src/main/kotlin/com/random/users/users/composable/UserCard.kt | Adjusted access levels and added a testTag to support UI testing. |
| gradle/libs.versions.toml | Removed mockitoKotlin dependency; added test-manifest dependency. |
| domain/src/test/kotlin/com/random/users/domain/usecase/GetUserListUseCaseUnitTest.kt | Added unit tests covering various scenarios for getting user lists. |
| domain/src/test/kotlin/com/random/users/domain/mother/UserMother.kt | Introduced a helper to create user test models. |
| data/src/test/kotlin/com/random/users/data/repository/UsersRepositoryUnitTest.kt | Added repository tests to verify data source interactions. |
| data/src/main/kotlin/com/random/users/data/mapper/UserMapper.kt & SeedMapper.kt | Changed object visibility from public to internal for encapsulation. |
| data/src/main/kotlin/com/random/users/data/di/DataModule.kt & data/src/main/kotlin/com/random/users/data/datasource/UsersApiDataSource.kt | Updated import paths to use the new UsersApi package. |
| core/* | Removed obsolete DispatcherRules and updated package for RoborazziRules. |
| core/api/src/main/kotlin/com/random/users/api/di/ApiModule.kt & core/api/src/main/kotlin/com/random/users/api/api/UsersApi.kt | Adjusted package names to align with updated API structure. |
| buildSrc/src/main/kotlin/AppVersions.kt | Increased app version code and name. |
| app/src/main/kotlin/com/random/user/navigation/RandomUsersNavHost.kt | Imported theme to improve UI consistency. |
| README.md | Enhanced documentation with clearer sections and updated formatting. |
Files not reviewed (3)
- app/build.gradle.kts: Language not supported
- gradle.properties: Language not supported
- presentation/users/build.gradle.kts: Language not supported
|
|
||
| val result = getUserListUseCase(1) | ||
|
|
||
| Assert.assertEquals(emptyList<String>().right(), result) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added remaining unit tests