Skip to content

Conversation

@xavierpellvidal
Copy link
Owner

Added remaining unit tests

@xavierpellvidal xavierpellvidal self-assigned this Apr 18, 2025
@xavierpellvidal xavierpellvidal changed the base branch from main to develop April 18, 2025 07:37
@xavierpellvidal xavierpellvidal marked this pull request as ready for review April 18, 2025 10:27
@xavierpellvidal xavierpellvidal requested a review from Copilot April 18, 2025 10:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the remaining unit tests and makes several codebase improvements. Key changes include:

  • Modifications to UserCard in the presentation layer (access modifiers and testTag additions).
  • Updates to dependency versions and module/package imports in gradle, data, and API modules.
  • Addition of new unit tests for use cases, repositories, and helper factories.
  • Documentation enhancements in the README and minor version bumping in the AppVersions file.

Reviewed Changes

Copilot reviewed 37 out of 40 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
presentation/users/src/main/kotlin/com/random/users/users/composable/UserCard.kt Adjusted access levels and added a testTag to support UI testing.
gradle/libs.versions.toml Removed mockitoKotlin dependency; added test-manifest dependency.
domain/src/test/kotlin/com/random/users/domain/usecase/GetUserListUseCaseUnitTest.kt Added unit tests covering various scenarios for getting user lists.
domain/src/test/kotlin/com/random/users/domain/mother/UserMother.kt Introduced a helper to create user test models.
data/src/test/kotlin/com/random/users/data/repository/UsersRepositoryUnitTest.kt Added repository tests to verify data source interactions.
data/src/main/kotlin/com/random/users/data/mapper/UserMapper.kt & SeedMapper.kt Changed object visibility from public to internal for encapsulation.
data/src/main/kotlin/com/random/users/data/di/DataModule.kt & data/src/main/kotlin/com/random/users/data/datasource/UsersApiDataSource.kt Updated import paths to use the new UsersApi package.
core/* Removed obsolete DispatcherRules and updated package for RoborazziRules.
core/api/src/main/kotlin/com/random/users/api/di/ApiModule.kt & core/api/src/main/kotlin/com/random/users/api/api/UsersApi.kt Adjusted package names to align with updated API structure.
buildSrc/src/main/kotlin/AppVersions.kt Increased app version code and name.
app/src/main/kotlin/com/random/user/navigation/RandomUsersNavHost.kt Imported theme to improve UI consistency.
README.md Enhanced documentation with clearer sections and updated formatting.
Files not reviewed (3)
  • app/build.gradle.kts: Language not supported
  • gradle.properties: Language not supported
  • presentation/users/build.gradle.kts: Language not supported


val result = getUserListUseCase(1)

Assert.assertEquals(emptyList<String>().right(), result)

This comment was marked as resolved.

@xavierpellvidal xavierpellvidal merged commit 135b163 into develop Apr 18, 2025
@xavierpellvidal xavierpellvidal deleted the featire/remaining-tests branch April 21, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants