Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes apache#1067.
This change adds explicit HDFS resource cleanup in the same spirit that the dataset JNI layer already does explicit lifecycle cleanup for S3. For S3, Arrow Java registers a shutdown hook that finalizes the native S3 subsystem. For HDFS, the leak happens through cached Hadoop
FileSysteminstances that keep non-daemon IPC threads alive, so the cleanup needs to happen whenFileSystemDatasetFactoryis closed.FileSystemDatasetFactorynow retains its input URIs and, onclose(), detects HDFS-backed URIs, normalizes and deduplicates the filesystem roots, and best-effort closes the corresponding cached HadoopFileSysteminstances. That releases the lingering IPC threads and allows the JVM to exit normally after HDFS dataset reads.This PR also adds a regression test using
MiniDFSClusterand a forked child JVM to show the behavioral difference:FileSystemDatasetFactorycleanup, the child JVM exits normallyTesting
mvn -Parrow-jni -pl dataset -Dmaven.gitcommitid.skip=true -Dtest=TestHdfsFileSystemCleanup testResult:
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0BUILD SUCCESS