feat: add approveRouter when mayachain-amm do-swap #1347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thorian1te
approved these changes
Feb 16, 2025
Thorian1te
reviewed
Feb 16, 2025
| * @param {Asset} asset to check | ||
| * @returns true if asset is ERC20, otherwise, false | ||
| */ | ||
| export const isProtocolERC20Asset = (asset: CompatibleAsset): asset is TokenAsset => { |
Collaborator
There was a problem hiding this comment.
this function can be imported from the package
isProtocolERC20Asset no need to rewrite it here
Author
There was a problem hiding this comment.
no, mayachain-amm package not export this function
Author
There was a problem hiding this comment.
mayachain-amm package only export types and mayachain-amm files.
but isProtocolERC20Asset implement in ./utils file.
so to import this, we should export ./utils file
Collaborator
There was a problem hiding this comment.
Btw the swap flow is meant to be like this
Estimate swap => (in here it will check for approval via validateSwap() ) => asset needs approval ? call approve() : doSwap()
its all clearly laid out in the read me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tried do-swap with mayachain-amm for real asset in EVM chains, it failes swapping.
So, I added approveRouter in mayachain-amm test file, it works well