XCOMP-1286: Migrate ReactiveXComponent in .NetStandard with TU in .NetCore #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .dll in packaging
…Component) && merge build in .csproj && delete task merge .cake
…stitute => compile TU with cake
|
Can one of the admins verify this patch? |
nicolaserny
requested changes
Feb 20, 2019
nicolaserny
left a comment
nicolaserny
left a comment
There was a problem hiding this comment.
You should also update the docker compose of the integration tests. We want to start the xcomp runtime with mono but start the test with dotnet core (to check that our reactive api really works with dotnet core)
…n system.reactive.link
nicolaserny
reviewed
Feb 22, 2019
nicolaserny
requested changes
Feb 22, 2019
… (and other include) to compile project helloWorld
…ed mono with xcomponent(in .netFramework) project in .sh
nicolaserny
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate ReactiveXComponent library in .NetStandard and change Test Unitaire in .NetCore
Change build.sh and build.ps1 to compile in dotnet
Change build.cake to launch ReactiveXComponent with cmd dotNetCore
Add in yml img microsoft/dotnet:2.1-sdk and download mono if we use it