Skip to content

Add clean parameter to json_read#202

Merged
rpreen merged 1 commit intoxcsf-dev:masterfrom
dpaetzel:add-clean-to-json_read
Jul 21, 2025
Merged

Add clean parameter to json_read#202
rpreen merged 1 commit intoxcsf-dev:masterfrom
dpaetzel:add-clean-to-json_read

Conversation

@dpaetzel
Copy link
Copy Markdown
Collaborator

Add a clean Boolean option to xcs.json_read to explicitly fix #197 if desired.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.58%. Comparing base (07fb6f0) to head (4b6d458).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files          61       61           
  Lines        8939     8939           
  Branches      933      933           
=======================================
  Hits         6310     6310           
  Misses       2629     2629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpaetzel
Copy link
Copy Markdown
Collaborator Author

I deliberately do not use the data() fixture for the tests but generate multiple datasets for each to ensure everything truly works (akin to property-based testing but manually). I hope that's OK.

@rpreen rpreen merged commit 0001f54 into xcsf-dev:master Jul 21, 2025
9 of 11 checks passed
rpreen pushed a commit that referenced this pull request Jul 21, 2025
@dpaetzel dpaetzel deleted the add-clean-to-json_read branch July 21, 2025 14:56
rpreen added a commit that referenced this pull request Jul 21, 2025
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/mirrors-clang-format: v20.1.7 → v20.1.8](pre-commit/mirrors-clang-format@v20.1.7...v20.1.8)
- [github.com/astral-sh/ruff-pre-commit: v0.12.2 → v0.12.3](astral-sh/ruff-pre-commit@v0.12.2...v0.12.3)

* Add checks for array contiguity (#199)

Fixes #198.

* Add `clean` parameter to `json_read` (#202)

* add Ruff Python linting/formatting

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: David Pätzel <david.paetzel@posteo.de>
Co-authored-by: Richard Preen <rpreen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Population loading/seeding using json_read is not working correctly

2 participants