Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #49 +/- ##
==========================================
- Coverage 82.15% 81.81% -0.35%
==========================================
Files 36 37 +1
Lines 4091 4151 +60
==========================================
+ Hits 3361 3396 +35
- Misses 730 755 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Add doc |
There was a problem hiding this comment.
Pull request overview
This PR adds a new function xdas.picking.tapered_selection to extract portions of waveforms around picks for magnitude estimation and cross-correlation. The implementation includes comprehensive test coverage and documentation.
- Adds
tapered_selectionfunction for selecting and tapering DataArray segments based on start/end values - Includes parallel JIT-compiled implementation using Numba for efficient processing
- Updates test files to use consistent
xdimport alias for the xdas module
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| xdas/picking.py | New module implementing tapered_selection with window-based tapering and parallel processing support |
| tests/test_picking.py | Comprehensive test suite covering basic functionality, window handling, size specification, and multi-dimensional selection |
| docs/api/picking.md | API documentation for the new picking module |
| tests/test_signal.py | Refactored to use consistent xd import alias instead of xdas |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xdas/picking.py
Outdated
| same size) NaN or NaT values indicate coordinates to ignored. | ||
| end : array-like | ||
| End values along the other dimension than `dim` (must be 1D and have the | ||
| same size) NaN or NaT values indicate coordinates to ignored. |
There was a problem hiding this comment.
The docstring contains grammatical errors. "indicate coordinates to ignored" should be "indicate coordinates to be ignored".
| same size) NaN or NaT values indicate coordinates to ignored. | |
| end : array-like | |
| End values along the other dimension than `dim` (must be 1D and have the | |
| same size) NaN or NaT values indicate coordinates to ignored. | |
| same size) NaN or NaT values indicate coordinates to be ignored. | |
| end : array-like | |
| End values along the other dimension than `dim` (must be 1D and have the | |
| same size) NaN or NaT values indicate coordinates to be ignored. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@atrabattoni I've opened a new pull request, #50, to work on those changes. Once the pull request is ready, I'll request review from you. |
Add
xdas.picking.tapered_selectionwith testsIt is mainly intended to extract portion of the waveforms around picks for magnitude estimation and/or cross-correlation.