fix: removes code execution indicator when process is terminated#368
Merged
felixfbecker merged 2 commits intoxdebug:mainfrom Dec 21, 2020
Merged
fix: removes code execution indicator when process is terminated#368felixfbecker merged 2 commits intoxdebug:mainfrom
felixfbecker merged 2 commits intoxdebug:mainfrom
Conversation
If the debugger is standing on a line and DBGp connection is interrupted (for example, php process terminated) the thread will go away, but the execution indicator will stay. Signaling a continued event before Thread exit solves this.
|
@felixfbecker any plans when this will be merged ? |
felixfbecker
changed the title
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the debugger is standing on a line and DBGp connection is interrupted (for example, php process terminated) the thread will go away, but the execution indicator will stay. Signaling a continued event before Thread exit solves this.