Skip to content

Add ignore option to ignore paths#66

Merged
felixfbecker merged 4 commits intomasterfrom
ignore
Jul 1, 2017
Merged

Add ignore option to ignore paths#66
felixfbecker merged 4 commits intomasterfrom
ignore

Conversation

@felixfbecker
Copy link
Copy Markdown
Contributor

@felixfbecker felixfbecker commented Oct 12, 2016

Closes #33
@VivPat @apit does this suit you?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 12, 2016

Codecov Report

Merging #66 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   62.06%   62.28%   +0.22%     
==========================================
  Files           5        5              
  Lines         825      830       +5     
  Branches      138      138              
==========================================
+ Hits          512      517       +5     
  Misses        256      256              
  Partials       57       57
Impacted Files Coverage Δ
src/phpDebug.ts 58.57% <100%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d2f77...4ea262d. Read the comment docs.

@apit
Copy link
Copy Markdown

apit commented Oct 18, 2016

@felixfbecker yes. unfortunately i'm unable to debug ignore branch using latest Insiders :-(

@felixfbecker
Copy link
Copy Markdown
Contributor Author

@apit why? Do the tests pass?

@xuanyou
Copy link
Copy Markdown

xuanyou commented Feb 18, 2017

@apit I've gotten this branch to work and debug properly. The one error I've noticed:

  • "Unexpected token ..." Check that your node version node -v is >= 5.x.x. Only Node 5+ supports the spread ... operator.

@felixfbecker This branch works great on my setup.

  • I'm running laravel and phpunit. The initial default ignore value **/vendor/*.php didn't exclude all subfolders, but once I changed it to **/vendor/**/*.php it worked. Same for phpunit, I added a **/phpunit/**/*.php and I could debug phpunit tests without error.
  • The test results are the same as 1.10. All the tests pass except for those that need a debugging connection. I'm getting timeouts on my machine for those tests, but it's the same for both the "1.10" tag and "ignore" branch.

@QwertyZW
Copy link
Copy Markdown
Contributor

QwertyZW commented Jun 22, 2017

Is this happening? I could really use this right now.

@felixfbecker
Copy link
Copy Markdown
Contributor Author

@QwertyZW could you try out this branch and test if it works fine for your?

@QwertyZW
Copy link
Copy Markdown
Contributor

QwertyZW commented Jun 30, 2017

It works as expected,

except that, like what @xuanyou mentioned, I had to use **/vendor/**/*.php instead of the default **/vendor/*.php

@felixfbecker
Copy link
Copy Markdown
Contributor Author

yeah, that makes sense. thanks for trying out

@felixfbecker felixfbecker merged commit a52ec5c into master Jul 1, 2017
@felixfbecker felixfbecker deleted the ignore branch July 1, 2017 12:13
@noorcs
Copy link
Copy Markdown

noorcs commented Nov 25, 2017

Can someone please tell me where do i need to add this:

**/directoryToBeIgnored/**/*.php

?

@felixfbecker
Copy link
Copy Markdown
Contributor Author

In launch.json

@felixfbecker
Copy link
Copy Markdown
Contributor Author

Please read the vscode debugging documentation https://code.visualstudio.com/docs/editor/debugging

@noorcs
Copy link
Copy Markdown

noorcs commented Nov 27, 2017

@felixfbecker Thanks for the link. I checked on the link, but did not find anyway to add the ignore option to the launch.json. The way way it has been explained here "2b68a85" does not work for me.

@felixfbecker
Copy link
Copy Markdown
Contributor Author

@noorcs can you post your launch.json?

@noorcs
Copy link
Copy Markdown

noorcs commented Nov 30, 2017

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Listen for XDebug",
            "type": "php",
            "request": "launch",
            "port": 9000,
            "ignore": [
                    "**/external/**/*.php",
                    "**/rtms/external/**/*.php"
                ]
        },
        {
            "name": "Launch currently open script",
            "type": "php",
            "request": "launch",
            "program": "${file}",
            "cwd": "${fileDirname}",
            "port": 9000,
            "ignore": [
                "**/external/**/*.php",
                "**/rtms/external/**/*.php"
            ]
        }
    ]
}`

@noorcs
Copy link
Copy Markdown

noorcs commented Dec 3, 2017

@felixfbecker any ideas why isn't it working for me? I have tried it with many different settings, but no success yet. I am using latest updated version of vscode insiders.

@bilogic
Copy link
Copy Markdown

bilogic commented Dec 24, 2018

Does this

  1. ignore errors
  2. or skip the file from debugging

I'm looking to skip, any ideas? Thank you.

@AnrDaemon
Copy link
Copy Markdown

I also look for ways to automatically step out of vendor code.

@AnrDaemon
Copy link
Copy Markdown

For the record, https://code.visualstudio.com/docs/editor/debugging does not mention any "ignore" functionality.

@bugproof
Copy link
Copy Markdown

I would prefer a whitelist that allows you to set paths you don't want to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excluding folder paths from debugging

9 participants