Skip to content

Conversation

@tonybaloney
Copy link

Previous behaviour:
premium users have to specify bearer_token in their credential files

New behaviour:
premium users can specify bearer token as before
they can also use consumer_key and consumer_secret in the creds YAML file. If this is specified, the bearer_token will be set on startup by a helper function inside the credentials submodule.

@tonybaloney
Copy link
Author

@binaryaaron

@binaryaaron
Copy link
Contributor

Thank you for the PR! I was quite literally adding a bearer token utility to the library and command-line interface.

I like where this is going, but I'll leave some specific feedback soon.

@binaryaaron
Copy link
Contributor

@tonybaloney - can you change the target of this PR to credential_updates? I'd like to integrate the bearer token functionality into the command-line app as an explicit command and will update the documentation as well.

@binaryaaron
Copy link
Contributor

Hey @tonybaloney - I'd love to merge this if you could change the target branch to credential_updates when you get a chance. Thanks!

@tonybaloney tonybaloney changed the base branch from master to credential_updates February 16, 2018 21:24
@tonybaloney
Copy link
Author

@binaryaaron done

@binaryaaron
Copy link
Contributor

Thanks!

@binaryaaron binaryaaron merged commit 9c1daa4 into xdevplatform:credential_updates Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants