Fix TwitterAds::Creative::PromotedTweet#save (#239)

[bugcloud]

• Fix invalid converting params

Issue Type: Bug

Fixes: #239

Changes Included:

• Fix invalid converting params
• Add test code of converting params

Check List:

• Includes adequate test coverage for changes made.
• Includes new or updated documentation.
• Includes new or updated usage examples.

[CLAassistant]

All committers have signed the CLA.

[tushdante]

Hey @bugcloud - Thanks for making this change. It looks like there's a couple linting errors that were detected. Could you resolve those and commit your changes?

[bugcloud]

@tushdante Thank you for replying. I fixed a lint error. f64ee61

Before

$ bundle exec rubocop spec/twitter-ads/creative/promoted_tweet_spec.rb
WARNING:  No private key present, creating unsigned gem.
Inspecting 1 file
C

Offenses:

spec/twitter-ads/creative/promoted_tweet_spec.rb:51:101: C: Line is too long. [165/100]
      expect(Request).to receive(:new).with(client, :post, "/#{TwitterAds::API_VERSION}/accounts/#{account.id}/promoted_tweets", expected_params).and_return(request)
                                                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected

After

$ bundle exec rubocop
WARNING:  No private key present, creating unsigned gem.
Inspecting 103 files
.......................................................................................................

103 files inspected, no offenses detected

[tushdante]

LGTM! Just wanted to confirm the description for the test

[tushdante]

I believe this converts params[:tweet_ids] to params[:tweet_id]

[bugcloud]

Oh really?
It seems that TwitterAds::Creative::PromotedTweet#save set params[:tweet_ids] from params[:tweet_id] .
(I followed this source code comment.)
https://github.com/twitterdev/twitter-ruby-ads-sdk/blob/master/lib/twitter-ads/creative/promoted_tweet.rb#L49

I have rewritten this description more clearly 🙇 eb4adb2