Ads api v10#255
Merged
Merged
Conversation
* Updates to switch to ios for Cards * Removing deprecated field salt * Removing deprecated field salt in tests * Add enum for Pay By Impression
* test ruby.yml * Update ruby.yml * Update ruby.yml * updated version to v9 * renamed/removed line item props * moved props out of beta * updated enums * added support for cards endpoint * renamed tailored audiences to custom audiences * removed old tailored audiences endpoint * added new cards endpoint with examples * updated tailored audiences to custom audiences * updated tests * merge conflicts * update lib/ audience_summary to audience_estimate * updated examples and tests * removed automatically_select_bid from line items
tushdante
approved these changes
Nov 18, 2021
Contributor
tushdante
left a comment
tushdante
left a comment
There was a problem hiding this comment.
LGTM! But want to call out that this item is unchecked in your checklist (looks like we already support card_type):
Review whether to add card_type for Cards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Ads API v10 - announcement
Issue Type: Improvement (Select One)
Fixes / Relates To: #123
Changes Included:
ipad_app_iddeprecation and rename toios_app_store_identifierautomatically_select_bidRemovewasn't supportedbidding_rulesendpointtracking_tagsand add newtracking tagsendpointtargeting_criteriafield deprecationsReview whether to addAlready supportedcard_typefor CardsCheck List:
For more information on check list items, please see the Contributors Guide.