Fix TwitterAds::Analytics.fetch_async_job_data for Ruby 3#256
Merged
Conversation
Closed
Contributor
|
Thanks for the changes. I'm going to merge this into a ruby v3 branch and test before releasing this. Let us know if you've found anything else that needs to get updated. |
osowskit
pushed a commit
that referenced
this pull request
Dec 24, 2021
* Ruby 3.0.0 Compatibility: Change &Proc.new to &block (#253) * Fix TwitterAds::Analytics.fetch_async_job_data for Ruby 3 (#256) * add back Account entity in Analytics class * add back Account entity in Analytics class * fix Kernel.open to URI.open * Add Ruby 3.0 to build matrix * Add support for latest Ruby version to readme Co-authored-by: margstan <79088430+margstan@users.noreply.github.com> Co-authored-by: Michele Ferri <ferrimiche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TwitterAds::Analytics.fetch_async_job_datamethod relies onopen-urioverride for theKernel.openmethod to read the job data url. This is broken in Ruby 3, so I changed it toURI.open.