Avoid logging OAuth1 access tokens#17
Open
Audacity88 wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop logging the OAuth1 access token value at INFO level after the browser OAuth flow completes.
Why
The existing log line persists a long-lived credential in normal logs for users who run the server under log redirection, containers, process supervisors, or hosted logging pipelines. The token is only needed to construct the OAuth1 client and does not need to be emitted for normal diagnostics.
Fixes #12.
Validation
python3 -c 'compile(open("server.py", encoding="utf-8").read(), "server.py", "exec")'git diff --check