Don't check srate for irregularly sampled streams#47
Merged
tstenner merged 3 commits intoxdf-modules:masterfrom Oct 7, 2019
Merged
Don't check srate for irregularly sampled streams#47tstenner merged 3 commits intoxdf-modules:masterfrom
tstenner merged 3 commits intoxdf-modules:masterfrom
Conversation
tstenner
reviewed
Oct 7, 2019
Contributor
Author
|
@tstenner feel free to merge if you're happy. I have another PR incoming that fixes more warnings, but I'd like to wait until this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
stream.srateis zero, we divided by zero in the effective vs. nominal srate check. This check should only be run for regularly sampled streams (i.e. withstream.srate> 0).