Add tests for example data to CI#49
Merged
cbrnr merged 11 commits intoxdf-modules:masterfrom Oct 23, 2019
Merged
Conversation
cbrnr
changed the title
Contributor
Author
Contributor
Author
|
@tstenner could you review this PR and merge if you're happy? We have some nice changes already and I'd like to release 1.16.2 as soon as this gets merged. |
tstenner
approved these changes
Oct 22, 2019
Contributor
tstenner
left a comment
tstenner
left a comment
There was a problem hiding this comment.
Two minor nitpicks, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: trying to implement testing using data in the example-files repo. Closes #38.