pping: Add graceful shutdown on SIGTERM #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also intercept SIGTERM (in addition the the previously intercepted SIGINT) and perform graceful shutdown. Perhaps it also makes sense to perform graceful shutdown on some additional signals, like SIGHUP and SIGQUIT? Signed-off-by: Simon Sundberg <simon.sundberg@kau.se>
Member
|
Yeah, just checking if a program with the same name is already attached should probably be fine for checking for already-running instances. It's unlikely that an unrelated application will install a program with the same name, after all... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPing previously only shut down gracefully on SIGINT, but did not handle SIGTERM which is the most common signal for killing a process non-interactively. Here I address that by simply adding the same signal-handler for the SIGTERM signal.
It may be worth considering if there are additional signals that should also be handled similarly, ex SIGHUP or SIGQUIT.
While not directly related, while I still remeber it @tohojo also suggested detecting if pping was already running on the interface, and then handle that. Is the correct way to do that to check for BPF-programs with the same name already attached to the interface and if found simply abort and inform the user that pping is already running?