tests: Run more MLIR conversion tests #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmiche
commented
Nov 25, 2022
| @@ -1,46 +1,49 @@ | |||
| // RUN: xdsl-opt -t mlir | xdsl-opt -t mlir -f mlir | filecheck %s | |||
Collaborator
Author
There was a problem hiding this comment.
This testcase seemed to forget that we are printing the generic IR for MLIR. I refactored it s.t. it now knows that.
webmiche
force-pushed
the
run_more_tests
branch
from
3c1dc11 to
28dfcf1
Compare
webmiche
force-pushed
the
run_more_tests
branch
2 times, most recently
from
7f88b15 to
0a3bde2
Compare
math-fehr
approved these changes
Nov 29, 2022
Collaborator
math-fehr
left a comment
math-fehr
left a comment
There was a problem hiding this comment.
Perfect! Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our MLIR conversion filecheck tests into tests that can be run without and with the Python bindings. Furthermore, it allows the former of the two be run in the CI.