Skip to content

ci: add Manki AI code review configuration#73

Merged
xdustinface merged 2 commits intov0.42-devfrom
chore-add-manki-config
Mar 30, 2026
Merged

ci: add Manki AI code review configuration#73
xdustinface merged 2 commits intov0.42-devfrom
chore-add-manki-config

Conversation

@xdustinface
Copy link
Copy Markdown
Owner

Summary

  • Add .manki.yml with project-specific review instructions for Dash protocol
  • Add .github/workflows/manki.yml workflow trigger

Manki is a multi-agent AI code review action that provides specialized review feedback. Configuration includes:

  • Auto-review on PR open/update
  • Auto-approve when findings are resolved
  • Instructions tailored for Dash protocol, consensus safety, FFI, and crypto
  • Excluded paths for lock files and fuzz corpus

@xdustinface xdustinface changed the title chore: add Manki AI code review configuration ci: add Manki AI code review configuration Mar 30, 2026
@manki-review
Copy link
Copy Markdown

manki-review Bot commented Mar 30, 2026

Manki — Review failed

✓ Parsed diff — 0 lines
✓ Review — 0 agents · 0 findings
✓ Judge — 0 kept · 0 dropped

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.38%. Comparing base (d8c394e) to head (e0e7d81).

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev      #73      +/-   ##
=============================================
- Coverage      67.50%   67.38%   -0.13%     
=============================================
  Files            318      318              
  Lines          67059    67059              
=============================================
- Hits           45268    45187      -81     
- Misses         21791    21872      +81     
Flag Coverage Δ
core 75.21% <ø> (ø)
ffi 36.68% <ø> (-1.01%) ⬇️
rpc 19.92% <ø> (ø)
spv 83.74% <ø> (+0.14%) ⬆️
wallet 66.96% <ø> (ø)
see 16 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@manki-review
Copy link
Copy Markdown

manki-review Bot commented Mar 30, 2026

Manki — Review complete

✓ Parsed diff — 47 lines
✓ Review — 3 agents · 5 findings
✓ Judge — 3 kept · 2 dropped

Review metadata

Config:

  • Models: reviewer=claude-opus-4-6, judge=claude-opus-4-6
  • Review level: small (auto, 47 lines)
  • Team: Security & Safety, Architecture & Design, Correctness & Logic
  • Memory: disabled
  • Nit handling: issues

Judge decisions:

  • ✓ Kept: "auto_approve enabled allows AI to merge without human review" (suggestion, medium confidence) — "Impact: High (AI-only approval on a crypto library could let dangerous changes through), Likelihood: Possible (depends on whether branch protection requires a human approver — if it does, this is harmless; if not, it's a real gap). Merged findings 1 and 3 — same issue flagged by two reviewers. Since branch protection config is unknown, this is worth flagging but not blocking."
  • ✓ Kept: "Workflow triggers on issue_comment without actor filtering" (suggestion, high confidence) — "Impact: Low-Medium (wastes CI minutes, and without actor filtering any commenter triggers the workflow), Likelihood: Probable (any issue comment triggers a run). Merged findings 2 and 4 — same underlying issue. The suggested if: github.event_name != 'issue_comment' || github.event.issue.pull_request guard is a straightforward fix."
  • ✓ Kept: "Consider excluding generated/vendored paths in addition to lock files" (nit, medium confidence) — "Impact: Low (unnecessary review comments on rarely-changed generated files), Likelihood: Unlikely (those files seldom appear in PRs). Minor improvement, correctly assessed as nit."

Recap:

  • 3 new findings

Timing:

  • Parse: 1.4s
  • Review agents: 19.0s
  • Judge: 16.9s
  • Total: 37.4s

Copy link
Copy Markdown

@manki-review manki-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds Manki AI code review tooling. Two findings stand out: auto_approve: true on a crypto protocol library should be reconsidered depending on branch protection rules, and the issue_comment trigger lacks a PR guard causing unnecessary workflow runs on plain issue comments.

Findings: 3 new

📊 3 findings (2 suggestion, 1 nit) · 47 lines · 37s

Review stats
{
  "model": "claude-opus-4-6",
  "reviewTimeMs": 37358,
  "diffLines": 47,
  "diffAdditions": 47,
  "diffDeletions": 0,
  "filesReviewed": 2,
  "agents": [
    "Security & Safety",
    "Architecture & Design",
    "Correctness & Logic"
  ],
  "findingsRaw": 5,
  "findingsKept": 3,
  "findingsDropped": 2,
  "severity": {
    "required": 0,
    "suggestion": 2,
    "nit": 1
  },
  "verdict": "APPROVE",
  "prNumber": 73,
  "commitSha": "e0e7d81fbd80ac5116c153aabce9bdf703454fdb"
}

Comment thread .manki.yml
Comment thread .github/workflows/manki.yml
@xdustinface xdustinface merged commit 76f5683 into v0.42-dev Mar 30, 2026
34 checks passed
xdustinface added a commit that referenced this pull request Mar 30, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 1, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 6, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 7, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 11, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 13, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 17, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request Apr 27, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
xdustinface added a commit that referenced this pull request May 4, 2026
* chore: add Manki AI code review configuration

* fix: pass `claude_code_oauth_token` to Manki action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants