Skip to content

Create get details#12

Merged
GachaDev merged 34 commits intomainfrom
11-create-get-details
Apr 9, 2025
Merged

Create get details#12
GachaDev merged 34 commits intomainfrom
11-create-get-details

Conversation

@GachaDev
Copy link
Collaborator

@GachaDev GachaDev commented Apr 1, 2025

Create logic of get details endpoint and tests

Base automatically changed from 7-create-search-endpoints to main April 9, 2025 08:32
Copy link
Collaborator

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking with @javipacheco , we thought that it would be nice to use Kotlinx Serialization: https://github.com/Kotlin/kotlinx.serialization

What do you think?

@GachaDev
Copy link
Collaborator Author

GachaDev commented Apr 9, 2025

After checking with @javipacheco , we thought that it would be nice to use Kotlinx Serialization: https://github.com/Kotlin/kotlinx.serialization

What do you think?

I’ve been looking into it, and I’ve noticed that Kotlinx Serialization doesn’t natively support XML. How would we go about handling XML in that case? Would we need to use another library alongside it?

@GachaDev GachaDev linked an issue Apr 9, 2025 that may be closed by this pull request
@GachaDev
Copy link
Collaborator Author

GachaDev commented Apr 9, 2025

After checking with @javipacheco , we thought that it would be nice to use Kotlinx Serialization: https://github.com/Kotlin/kotlinx.serialization
What do you think?

I’ve been looking into it, and I’ve noticed that Kotlinx Serialization doesn’t natively support XML. How would we go about handling XML in that case? Would we need to use another library alongside it?

I tried to use https://github.com/pdvrieze/xmlutil and https://github.com/rharter/kotlinx-serialization-xml but there is a lot of problems and dont have a json ignore unknown properties

@Montagon
Copy link
Collaborator

Montagon commented Apr 9, 2025

After checking with @javipacheco , we thought that it would be nice to use Kotlinx Serialization: https://github.com/Kotlin/kotlinx.serialization
What do you think?

I’ve been looking into it, and I’ve noticed that Kotlinx Serialization doesn’t natively support XML. How would we go about handling XML in that case? Would we need to use another library alongside it?

I tried to use https://github.com/pdvrieze/xmlutil and https://github.com/rharter/kotlinx-serialization-xml but there is a lot of problems and dont have a json ignore unknown properties

Cool, no problem. We can keep Jackson then. Thanks!!

@GachaDev GachaDev added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit 3d570ba Apr 9, 2025
@GachaDev GachaDev deleted the 11-create-get-details branch April 9, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create GET /details

2 participants