Allow reflection-docblock v6 & fix mixin generation in Windows#80
Conversation
📝 WalkthroughWalkthroughWorkflows updated to newer action versions; Composer settings, dependency constraints, and scripts adjusted; README example namespace fixed; .gitignore expanded; multiple unit tests were namespaced or updated to use fully-qualified Faker instantiation. Changes
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
martinsoenen
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR !
A lot of interesting adjustments. We just need to ensure maximum packages compatibility :)
|
Added a new But in my testing, this only works when installing for development, in production this command should not be placed in Besides that, the mixing is not working, as is not referenced anywhere in the package so you don't get autocompletion, and still get a lot of phpstan errors. For now i think this is ok, as this pr is intended to fix psr-4 issues, autoloading and allow |
|
Thanks for the replies, This is really strange because on my side it works in multiple different environments. I need to try more. Can you please create issues with reproductible problems for the mixin things ? I will take a look at this PR today or tomorrow to ensure your changes are OK for me. It seems good and interesting :) |
I tested it on a laravel proyect, with the laravel integration and I got the but maybe is my setup, need to test more. |
martinsoenen
left a comment
There was a problem hiding this comment.
Ok thanks ! Let's go !
This PR updates
composer.jsonto allowreflection-docblockv6, with range"phpdocumentor/reflection-docblock": "^5.6|^6.0", no breaking changes.Also does some cleaning:
Node.js 20 actions are deprecated)faker_mixin.phpandpackages.phpphpunitto v12, which requiresphp >= 8.3, same as current supported php version, and receives bugfixes until February 5, 2027Summary by CodeRabbit
Chores
Tests
Documentation