Skip to content

Add with-fee-rule argument and header to create_charge method of CreditCard class#61

Merged
flamehamster merged 2 commits intoxendit:masterfrom
erikduisheev:add-with-fee-rule-argumant-and-header-to-create-credit-card-charge
Feb 9, 2023
Merged

Add with-fee-rule argument and header to create_charge method of CreditCard class#61
flamehamster merged 2 commits intoxendit:masterfrom
erikduisheev:add-with-fee-rule-argumant-and-header-to-create-credit-card-charge

Conversation

@erikduisheev
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread xendit/models/creditcard/credit_card.py
Copy link
Copy Markdown
Contributor

@msmur msmur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick otherwise LGTM
Please change the package version https://github.com/xendit/xendit-python/blob/master/pyproject.toml to 0.2.1

@erikduisheev
Copy link
Copy Markdown
Contributor Author

Just a nitpick otherwise LGTM Please change the package version https://github.com/xendit/xendit-python/blob/master/pyproject.toml to 0.2.1

Done

Copy link
Copy Markdown
Contributor

@msmur msmur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flamehamster flamehamster merged commit 2bc1ef9 into xendit:master Feb 9, 2023
@erikduisheev erikduisheev deleted the add-with-fee-rule-argumant-and-header-to-create-credit-card-charge branch April 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants