Attach memory area reference to DirectByteBuffers#52
Merged
xerial merged 1 commit intoxerial:developfrom Dec 13, 2016
Merged
Conversation
This avoids garbage collection of the LBufferAPI instance as long as DirectByteBuffers referring to the LBufferAPI memory area are alive. Failing to do keep the reference results in a SIGSEGV from the JVM after a GC run.
maciej
changed the title
DirectByteBuffers
Owner
|
Merged. Thanks for the fix! |
Contributor
Author
|
You're welcome! Thank you for merging it! |
Jackie-Jiang
added a commit
to apache/pinot
that referenced
this pull request
Feb 22, 2021
Upgrade the larray version to include the fix: xerial/larray#52 Also fix the issue of not able to load large index if it shows up first in `SingleFileIndexDirectory`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids garbage collection of the
LBufferAPIinstance as long asDirectByteBuffers referring to theLBufferAPImemory area are alive.Failing to do keep the reference results in a segmentation fault upon access to the
DirectByteBufferafter a GC run.