refactor: Simplify type checks in getColumnType using Sets
#1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced complex and repetitive conditions with `Set` collections for type names. - Improved readability and maintainability by grouping related type names. - Added sets for boolean, integer, float, text, and blob types. This change does not affect functionality but makes the code cleaner and easier to maintain.
Collaborator
|
you are going to define those sets every time the function is called. Extracting could be useful if the comparisons were done more than once, but it's not the case. Adds complexity for nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setcollections for type names.This change does not affect functionality but makes the code cleaner and easier to maintain.