Add native libs for Android arm64, x86, x86_64 via dockcross#662
Merged
xerial merged 7 commits intoxerial:masterfrom Sep 20, 2021
Merged
Add native libs for Android arm64, x86, x86_64 via dockcross#662xerial merged 7 commits intoxerial:masterfrom
xerial merged 7 commits intoxerial:masterfrom
Conversation
xerial
reviewed
Sep 20, 2021
| } | ||
|
|
||
| @Nested | ||
| @SetSystemProperty(key = "java.runtime.name", value = "Java for Android") |
Owner
There was a problem hiding this comment.
Interesting. I didn't know there is such a feature.
Collaborator
Author
There was a problem hiding this comment.
The library also has some rules to make it easier to work with stdin and stdout, I might try to refractor some of the existing code at some point.
xerial
reviewed
Sep 20, 2021
| import java.io.InputStream; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| public class ProcessRunner { |
Owner
|
Looks good. Thanks for refactoring and enhancing the Android support! |
Willena
added a commit
to Willena/sqlite-jdbc-crypt
that referenced
this pull request
Jan 15, 2022
* Tried updating github actions file * Add CI tests for aarch64 and armv7 (xerial#658) * multiarch test * cleanup before PR * revert file * fix action version * update CI badge on README.md (xerial#661) * Switch to Temurin JDK builds as AdoptJDK has been discontinued (xerial#660) * Update Eclipse settings to use Java 8 (xerial#664) * Fix file descriptor (handle) leak when opening database fails (xerial#665) xerial#431 * Add native libs for Android arm64, x86, x86_64 via dockcross (xerial#662) * cleanup OSInfo.java with IDE suggestions * add native build for android aarch64, x86 and x86_64 * add android native builds * change native lib resolution for Android * refactor for tests in OSInfo.java * add missing test scope for mockito dep * add new targets to native-all * Use more specific types instead of String when fetching JDBC3ResultSet.getBigDecimal (xerial#666) * detect musl by checking /proc/self/map_files (xerial#675) * detect musl by checking /proc/self/map_files * spotless:apply * Update src/main/java/org/sqlite/util/OSInfo.java Co-authored-by: Roman Parshikov <promansew@gmail.com> * spotless:apply Co-authored-by: Roman Parshikov <promansew@gmail.com> * let's start by testsing ;) * Let's try building natives * Add missing packages * Another try * Maximise build space :) * in fact might not be needed. Just removing dirs ! * Removed freebsd32 freebsd64 freebsd-arm64 temporarily * Add missing Linux-aarch64 def * Updated compile option for Android x86 and Android x64 * Added Package target and build binary zip ! * Now download specific SQLite3MC versions * Updated existing "quick" tests * Revert removing dependency in pom.xml * Fixing build with theses changes ? * Revert version upgrades in pom.xml * Fixed CI errors (windows build) * Small fix for strip * Moved to curl as it works best * Removed outdated version of OSInfo.class; Updated Makefile.common to rebuild it if missing. * Applied spotless fixes * Upgrade SQLite3MC to 1.3.4 - 3.36.0 * Configured credentials for auto-deploy Co-authored-by: Gauthier <gotson@users.noreply.github.com> Co-authored-by: Carl Dea <carl.dea@gmail.com> Co-authored-by: Taro L. Saito <leo@xerial.org> Co-authored-by: Andy-2639 <Andy-2639@users.noreply.github.com> Co-authored-by: Andrey.Tarashevskiy <fantocci@gmail.com> Co-authored-by: Roman Parshikov <promansew@gmail.com>
This was referenced Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #659
Following #659 (comment) I went for a dedicated folder
Linux-Androidwhich is IMHO easier to understand than the prefix/suffix notation.I had to refactor
OSInfoto be able to better test it. Static classes are difficult to test, but I also didn't want to change the contract or make it a non-static class.I am bringing 2 new dependencies, only on the test scope:
I also changed a bit the
Makefile.commonto make use of some of the Dockcross variables likeCROSS_ROOT.