fix: multiple Human in the loop approvals getting stuck#475
Merged
xerrors merged 1 commit intoxerrors:mainfrom Jan 15, 2026
Merged
fix: multiple Human in the loop approvals getting stuck#475xerrors merged 1 commit intoxerrors:mainfrom
xerrors merged 1 commit intoxerrors:mainfrom
Conversation
Add check_and_handle_interrupts call to resume_agent_chat function to make it consistent with the main chat flow. Root cause: - Main chat flow checks for pending interrupts after stream ends - Resume flow was missing this check - When a new interrupt was triggered after resume, frontend never received the new approval request Fix: - Add the same interrupt detection logic after stream ends in resume flow
Owner
|
感谢 PR！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #453: When multiple Human in the loop tool calls occur in a single conversation, the second call gets stuck.
Change Type
Root Cause
stream_agent_chat) checks for pending interrupts after streaming ends by callingcheck_and_handle_interruptsresume_agent_chat) was missing this checkinterrupt()was triggered after resume, the frontend never received the newhuman_approval_requiredmessage, causing the conversation to appear stuckFix
Added
check_and_handle_interruptscall toresume_agent_chatfunction after stream ends, making it consistent with the main chat flow.Testing
Related Issue
Closes #453