Remove libmagic dependency#58
Merged
Merged
Conversation
hoytak
reviewed
Jul 19, 2023
|
I like it, +100.
|
Contributor
There are extension collisions in that wiki list. Definitely need some manual screening there. |
Contributor
Author
seanses
approved these changes
Jul 19, 2023
|
Sounds good to me! |
This was referenced Jul 20, 2023
Merged
hoytak
pushed a commit
that referenced
this pull request
Jul 20, 2023
Caused by #58 -- did not run tests before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for removing libmagic are numerous, but the main ones are:
This PR replaces file type detection using libmagic with a file-extension based lookup (see
file_types.rs). The lookup table is from file extension to mime type and friendly name, and uses phf for efficient compile-time construction of the hash table.