Kb fix segfault vera presnmass #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he iterator that goes up to 1e5 even though mc_co and mc_he are of size 2, so memory gets overwritten and eventually busses. rip
Owner
|
I looked at the calls in your comenv.f folder, and back to the previous bugfix PR (COSMIC-PopSynth#700) And double checked the ordering of the outputs, and they look good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much ado -- and a winter break -- I found the segfault that was breaking when we set the radius with comprad. the new core mass arrays are only size 2 so when we write to index ~huge, we overwrite some memory that eventually becomes problematic.
We should now have a PR that passes tests and adds the mass of the core helium and carbon-oxygen layers. :phew: