Adding async attribute to the WP JS scripts #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub300
requested changes
Aug 29, 2017
There was a problem hiding this comment.
Unfortunately life is not that simple,
many things will break with code like that. For example gravity forms relies on jQuery loaded synchronously and it has it's own script that must be loaded before DOMContentLoaded.
If you know that it's safe to load wp-embed asynchronously then please do but anything global has too many possible side effects.
|
@jakub300 thanks for pointing that out. Can you check this update version, I've tried to make it more generic. |
jakub300
reviewed
Aug 31, 2017
jakub300
previously approved these changes
Aug 31, 2017
jakub300
approved these changes
Aug 31, 2017
|
Tested and seems to be working. |
|
Thanks, I'll do those changes yet on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Performance class for performance optimization code. By default it adds async attribute to JS scripts in WP ( in particular wp-embed.js which is added by default by WP)